-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tools view regeneration on a PR level for manual tools #2124
Comments
Hi @derberg, I would like to work on this issue. Can you please assign this to me. |
please go ahead @Arbtrage |
@Arbtrage any updates? |
Hey @akshatnema , I am still searching for a solution for this issue. Can you guide me on some approaches ? |
Hey @derberg and @akshatnema, I would like to work on this. The solution I am considering involves having two workflows: The The What are your views on this? |
We already have automatic workflow to update the tools every Monday. We only want to check for manual tools and update the manual tools of there is any changes in the file. |
Hey @derberg and @akshatnema, For the PR preview workflow, the approach I'm considering is to:
What are your thoughts on this? Am I on the right track? If not, could you please guide me further? |
@akshatnema correct me if you do not agree but imho the right way is: because we already have https://github.com/asyncapi/website/blob/master/package.json#L16C5-L16C53 script to build tools, what has to be done is:
thoughts? |
Yeah @derberg, that's what I think of to have a separate file to check for manual tools and run that file only for each PR checks. We can do that using |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Context
This page: https://www.asyncapi.com/tools
Gets regenerated once a week (or anytime by manual trigger) thanks to https://github.com/asyncapi/website/blob/master/.github/workflows/regenerate-tools.yml
Basically this script is called: https://github.com/asyncapi/website/blob/master/scripts/build-tools.js
More info about entire solution you can find in: https://github.com/asyncapi/community/blob/master/new-tool-documentation.md
Problem/Limitation
So people can add tools also manually to the website, through a PR: #2114
But problem is, that tools (as mentioned above) are not refreshed during website build, which means preview on PR level do not reflect PR changes.
No-go solution
Solution is not to rebuild tools, with the same script that we have now, on build level. We use logs of GH API there and do not want to run out of credits too soon
The text was updated successfully, but these errors were encountered: