-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsyncAPI v3 related changes and website freeze #1650
Comments
I don't think there is a better solution. we just need to remember to not SEO @alequetzalli @akshatnema we need your input and agreement |
Minor comment: it should be And yeah as I said in the meeting I agree with that. |
Will |
Depends on how you want to achieve it, in the meeting we discussed that it could just be a read-only format, where we could have adapted it to link to v3 in all the relevant pages. |
with Idea is that it is just one-time created old view of old docs. Just for reference |
Yes, versioning and specifying a unique URL for the old v2 docs is the best practice. |
Can one of you create the branch |
Wait, I am missing some context here 😅 .. why do you need us to create a branch? Why can't you do it yourself? @jonaslagoni I feel like there is a secret I don't know about hehe 🙃 |
It's one way we can collaborate on spec 3.0 changes to the website and slowly progress the change, we discussed it a bit in the last meeting. The best way forward we saw was to:
This enables us to merge all website 3.0 changes progressively without waiting for the specification to release, cause it's still unknown when that will happen. So whenever the spec is finally released, whatever documentation we have for spec 3.0 can be released by just merging At least that's the idea 😄 |
Yes, using a feature branch called But I'm still confused about why you needed me or Lukasz specifically to create that branch? 😂 😅 Wouldn't it make more sense for you to create the branch if you are the one making changes? (please excuse me if I am still missing something obvious!) |
I can only create a branch in my fork, which is by no means optimal for a feature branch. I would love to do it myself, however I am not a codeowner in the website 😄 It is much better to have the branch created here cause it's easier for everyone to access. |
Let me know if that made sense @alequetzalli 🙂 |
Ooooooh! I haven't created a feature branch yet and was unfamiliar with the process, so that was my confusion. Yes, I think I finally understood you now. I will research how feature branches work and create one next week. I may ask Lucasz if I get stuck.😂🤪 |
@alequetzalli it is very simple (takes 10 seconds), if you go to https://github.com/asyncapi/website/branches You can create the branch |
Is this all good? 😄 |
@alequetzalli yep, perfect 👌 |
just leaving a note for future. Let's make sure this will not be needed, but might be that we will later on in the process rename as opposite to initial assumption: I know we do not want to invest long term in old docs, but this repo is not only docs but also server configuration, redirects, and other stuff that we might need to adjust later minimum is to add a |
well, it doesn't make sense what I wrote ☝🏼 just forget it in general, for context https://youtu.be/dRu9itGfJ1E?t=668 additional stuff that needs to be done NOW:
additional stuff that needs to be done BEFORE RELEASE:
cc @jonaslagoni @alequetzalli |
I think I got it, but I will definitely have some questions in my 1:1 to make sure I don't mess up the new plans for the Question: Why does your latest comment say "create v2 branch out of master" but the previous one says we will rename |
please look at my first sentence: in short: |
ah! NOW I follow you better 😂 So we are going to create a new feature branch called p.s. everything else you mention looked correct to me |
yes, |
https://v2.asyncapi.com/ is here 🥳 |
done |
Reason/Context
In the last spec 3.0 meeting we discussed how we could slowly make changes to the website to fit it for v3 while still giving users access to v2 resources. We landed on the following suggestions:
next_major_spec
(this is what all other tools are using) to merge any related v3 changes into. Once we release v3, we merge that branch intomaster
.v2.asyncapi.com
.What do you think?
The text was updated successfully, but these errors were encountered: