feat: edavisualizer applicationView integration #243
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Om-Thorat
changed the title
Variable names are according to the standard camelCase naming conventions so it's often that some will overlap. Very sorry you feel as such, most i can do is assure you it's independent work and i had to make this PR as a part of the proposal for the mentorship program since it was a step in the process. |
|
yes, PR #242 was almost ready to be merged already.. I can not tell if PR #243 is a copy or not, but the work was already in progress... anyway I like the naming in commands #243 @ibishal can you update command names acordingly If you have any question regarding mentorship program, please contact @AceTheCreator |
Done 👍 |
I made this PR according to the instructions in Since it was a requirement before I share the proposal. I am unsure will my proposal be considered? I have texted Ace on Slack yet i am asking you since you are the mentioned mentor and you are the one I am supposed to share it with. Sorry if i am misunderstanding. Thanks. |
|
@ibishal @Om-Thorat Thank you for your interest in @ivangsa project idea. I understand that there are concerns regarding similar PRs and potential code copying. I’ve spoken with the mentor, Ivan, and here are a few points I want to clarify: The PR submission is one of the several criteria @ivangsa will use to evaluate candidates. Ivan will look at the overall proposal, quality of the work, and other requirements before making any decisions. Similarities in PRs can happen, especially when working on a specific task, so this will not be the sole criteria for selection. Please be rest assured that Ivan will review all PRs carefully and fairly. Please, let’s maintain a spirit of collaboration as we move forward. Thank you all for your hard work and awesome contributions to the project 🚀 |
|
Thank you for the clarification :) |
Description
Demo video
edavisualiserdemo.webm
Related issue(s)
Resolves #234