Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add complete markdown preview #212

Merged
merged 7 commits into from
Mar 10, 2024
Merged

feat: add complete markdown preview #212

merged 7 commits into from
Mar 10, 2024

Conversation

nikhilkalburgi
Copy link
Contributor

Description

I have completed building the markdown preview.

09.03.2024_23.06.17_REC.mp4

The following are the topics that should be taken care of in the future.

Order Topics
1 Testing and Debugging the developed Markdown Preview
2 Enhancement in the Markdown Preview
3 Building the Flowchart Preview
4 Planning for the Class Diagram Preview
5 Adding Support for export
6 Adding Support for Avro Syntax
7 Other functions like sync, etc.

I want to continue these tasks with the GSOC24. I will submit the proposal on the GSOC portal for this Project Idea as well as for the AutoFix feature. 🙏🏼Please consider my application, if these ideas are selected for GSOC. So that I can continue here with my full potential. 😊However, I can continue with the planning and design of this feature + research on the AutoFix feature (which I have already started).

Thank You for this Opportunity,
Nikhil S Kalburgi

Copy link

sonarcloud bot commented Mar 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

h1 {
color: #121212;
}
html{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving this css to a separate file

Copy link
Collaborator

@ivangsa ivangsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Consider this canges for next version. I'm merging this.. Thanks!!

@@ -0,0 +1,3 @@
<%- include(path.infoPath,{...info,tagsPath: path.tagsPath}) %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this renders even with an incomplete/invalid spec

@ivangsa
Copy link
Collaborator

ivangsa commented Mar 10, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 940e6e1 into asyncapi:feature/mermaid-markdown Mar 10, 2024
8 of 10 checks passed
@nikhilkalburgi
Copy link
Contributor Author

nikhilkalburgi commented Mar 23, 2024

HI @ivangsa,

I will take care of the changes you have suggested along with the development of the flowchart and class diagram. I have also submitted the proposal to GSOC 24 Asyncapi Organization. Can you please take some time to review it and share some feedback on that?

Link: https://summerofcode.withgoogle.com/proposals/details/VWgaUPLQ
Link: https://summerofcode.withgoogle.com/proposals/details/VD5hQ4Zn (AutoFix)

@nikhilkalburgi
Copy link
Contributor Author

Hi @ivangsa,
Sorry! I have shared the GSOC link which is probably not accessible.
Find the attached draft proposal in PDF format:
AsyncAPI_VS_Preview_Mermaid_Markdown.pdf
AsyncAPI_VS_AutoFix.pdf

@ivangsa
Copy link
Collaborator

ivangsa commented Mar 26, 2024

Hi @nikhilkalburgi

you have done a great job on this feature, not finished yet but good work..

It's probably not me how is going to mentor the gsoc as a new team is going to get in charge of this project...

Rest assured that your proposal would be evaluated acordingly... as I'm in contact with all the team..

By the time being, if you enjoy it.. keep contributing to opensource..

Should you need anything else I'll be arround here in github

Happy coding to you!!

@nikhilkalburgi
Copy link
Contributor Author

Hi @ivangsa,

I hope you are doing great. This is to inform you that I am now selected as GSOC 2024 contributor for this project idea. My mentor is Ace (According to the GSOC Dashboard).

Should I continue with work that we planned together or should I follow up with my mentor in GSOC with a different working approach?

Thank you for the recognition.

@ivangsa
Copy link
Collaborator

ivangsa commented May 3, 2024

hi @nikhilkalburgi, congratulations!!

you should follow Ace instructions for anything GSOC related... and you can continue this line of work
I will continue to review your PRs

I'm in direct contact with @AceTheCreator in the slack channel, so no worries about it..

This being said, for me you are just another fellow opensource developer and contributor

so Happy Coding!!

@nikhilkalburgi
Copy link
Contributor Author

Thank you so much 🙂 . I will continue my work here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants