Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: included caching in add-new-version.js. #552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Manush-2005
Copy link

Description

  • This file had too many fs read and write operations.
  • Included cache which reads data from all files and returns the writes final cache at the end of execution( addNewVersion function).
  • ReadJsonFile - Reads File and puts it in cache.
  • WriteJsonFile - Required cache file is written back.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

sonarcloud bot commented Jun 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Manush-2005
Copy link
Author

Manush-2005 commented Aug 25, 2024

Just a friendly ping on this why this PR is still open @Pakisan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant