Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement extended tests for bindings and AsyncAPI v3.0.0 definitions #551

Closed
2 tasks done
Pakisan opened this issue Jun 15, 2024 · 11 comments
Closed
2 tasks done

Implement extended tests for bindings and AsyncAPI v3.0.0 definitions #551

Pakisan opened this issue Jun 15, 2024 · 11 comments
Assignees
Labels
bounty AsyncAPI Bounty program related label enhancement New feature or request

Comments

@Pakisan
Copy link
Member

Pakisan commented Jun 15, 2024

Why do we need this improvement?

I have already wrote basic tests for bindings and AsyncAPI v3.0.0 definitions

Now, it's time to tune them up

I expect next:

Initial tests are here: #540
Related issue, witch schemas new format: #549

How will this change help?

We will be sure that after changes in our schemes nothing will be broken

Screenshots

No response

How could it be implemented/designed?

Tune up basic tests

🚧 Breaking changes

No

👀 Have you checked for similar open issues?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

Yes I am willing to submit a PR!

@Pakisan Pakisan added the enhancement New feature or request label Jun 15, 2024
@Pakisan Pakisan changed the title Implements extended tests for bindings and AsyncAPI v3.0.0 definitions Implement extended tests for bindings and AsyncAPI v3.0.0 definitions Jun 15, 2024
@Pakisan Pakisan self-assigned this Jun 15, 2024
@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label Jun 17, 2024
@aeworxet
Copy link

Bounty Issue's service comment

Text labels: bounty/2024-Q3, bounty/advanced, bounty/coding
First assignment to third-party contributors: 2024-06-21 00:00:00 UTC+12:00
End Of Life after: 2024-07-31 23:59:59 UTC-12:00

@asyncapi/bounty_team

The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.
Third-party contributors should coherently articulate how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue.

@aeworxet
Copy link

Bounty Issue's Timeline

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2024-06-15 2024-07-01 2024-08-25 2024-07-21 2024-08-11 2024-08-25
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 2, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 2, 2024
@aeworxet
Copy link

@Pakisan, please provide the Draft PR.

Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 24, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 24, 2024
@Pakisan
Copy link
Member Author

Pakisan commented Jul 24, 2024

@aeworxet #540

Few tests left

Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 25, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 25, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 25, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 25, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Jul 26, 2024
@Pakisan
Copy link
Member Author

Pakisan commented Jul 26, 2024

@aeworxet #540

Few tests left

Tagged folks in PR

@aeworxet
Copy link

Review for PR #540 was requested on 2024-07-26, and it is still in progress.

@aeworxet
Copy link

@Pakisan

Do you need more reviews of PR #540 or reviews

#540 (review)
#540 (comment)

have been enough and you already have an understanding of what to do next?

@aeworxet
Copy link

Responses, critical for technical resolution of this Bounty Issue (review of the PR) were delayed for three periods of three consecutive working days
#540 (comment)
#540 (comment)

so all remaining target dates of the Bounty Issue's Timeline are extended by four calendar weeks.

Bounty Issue's Timeline Extended

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2024-06-15 2024-07-01 2024-09-22 2024-08-18 2024-09-08 2024-09-22
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Sep 2, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Sep 2, 2024
Pakisan added a commit to Pakisan/spec-json-schemas that referenced this issue Sep 2, 2024
@Pakisan
Copy link
Member Author

Pakisan commented Sep 19, 2024

#540 contains both double work result:

  • initial tests for our schemes, like info, server, security - that’s how this MR appeared
  • extended tests from 551 - by this I added common tests structure with declared requirements like extended, wrongly extended, properties checking and so on

Everything else is out of scope of this issue:

So this Bounty Issue is completed.

@Pakisan Pakisan closed this as completed Sep 19, 2024
@aeworxet
Copy link

Bounty Issue Is Completed 🎉

@Pakisan, please go to the AsyncAPI page on Open Collective and submit an invoice for USD 400.00 with the expense title Bounty spec-json-schemas#551, tag bounty, and full URL of this Bounty Issue in the description.

@Pakisan
Copy link
Member Author

Pakisan commented Sep 20, 2024

Bounty Issue Is Completed 🎉

@Pakisan, please go to the AsyncAPI page on Open Collective and submit an invoice for USD 400.00 with the expense title Bounty spec-json-schemas#551, tag bounty, and full URL of this Bounty Issue in the description.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty program related label enhancement New feature or request
Projects
Status: Completed
Development

No branches or pull requests

3 participants