Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump ajv to 8.17.1 #1042

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

aeworxet
Copy link
Contributor

This PR upgrades ajv to version 8.17.1 to lay the foundation for fixing #980.

Related to #1012

@aeworxet
Copy link
Contributor Author

@asyncapi/bounty_team

@smoya
Copy link
Member

smoya commented Jul 25, 2024

@aeworxet If we want to release this, you will need to include a changesets file under .changeset dir. Check the following message from changeset-bot.

Copy link

changeset-bot bot commented Jul 25, 2024

🦋 Changeset detected

Latest commit: 7968a56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aeworxet
Copy link
Contributor Author

$ npx changeset
npm ERR! could not determine executable to run


$ npm install npx -g --force
npm WARN using --force Recommended protections disabled.
npm WARN deprecated [email protected]: This package is now part of the npm CLI.

added 1 package in 3s

1 package is looking for funding
  run `npm fund` for details


$ npx changeset
npm ERR! cb.apply is not a function

🤷🏻

@ayushnau ?

@ayushnau
Copy link
Contributor

ayushnau commented Jul 25, 2024

the command for the cli to create changeset is this npx -p @changesets/cli changeset @aeworxet

@aeworxet aeworxet force-pushed the chore-deps-bump-ajv-to-8.17.1 branch from 1836812 to 7968a56 Compare July 25, 2024 11:35
Copy link

sonarcloud bot commented Jul 25, 2024

@aeworxet
Copy link
Contributor Author

Should command npx -p @changesets/cli changeset be written in a README somewhere? I wouldn't know it if @ayushnau didn't tell.

$ grep -iHr changesets/cli .
./node_modules/eslint-plugin-prettier/package.json:    "@changesets/cli": "^2.27.1",
./.github/workflows/release-with-changesets.yml:          version: npx -p @changesets/cli changeset version
./.github/workflows/release-with-changesets.yml:          publish: npx -p @changesets/cli changeset publish

@smoya
Copy link
Member

smoya commented Jul 26, 2024

Click here if you're a maintainer who wants to add another changeset to this PR

Sure, feel free to add it. cc @ayushnau
BTW, you have a link in #1042 (comment) that redirects you to create the file.

@aeworxet
Copy link
Contributor Author

#1042 (comment) redirects to

Run npx changeset or yarn changeset

while @ayushnau pointed to

npx -p @changesets/cli changeset

That's why I thought this matter needed clarification. 🤷

Anyway, I've already added the changeset because I need to specify a new version of @asyncapi/parser in PR for both Studios; can this PR be merged?

@smoya
Copy link
Member

smoya commented Jul 27, 2024

#1042 (comment) redirects to

Run npx changeset or yarn changeset

while @ayushnau pointed to

npx -p @changesets/cli changeset

That's why I thought this matter needed clarification. 🤷

Anyway, I've already added the changeset because I need to specify a new version of @asyncapi/parser in PR for both Studios; can this PR be merged?

The last link of such comment redirects you right directly to the changeset file creation: https://github.com/aeworxet/asyncapi-parser-js/new/chore-deps-bump-ajv-to-8.17.1?filename=.changeset/mean-mice-buy.md&value=---%0A%22%40asyncapi%2Fparser%22%3A%20patch%0A---%0A%0Achore(deps)%3A%20bump%20ajv%20to%208.17.1%0A
Next time you can use it.

@smoya
Copy link
Member

smoya commented Jul 27, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit b032f3a into asyncapi:master Jul 27, 2024
10 checks passed
@aeworxet aeworxet deleted the chore-deps-bump-ajv-to-8.17.1 branch July 27, 2024 08:14
@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

4 participants