Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parameter for channel #345

Closed
Tenischev opened this issue Oct 22, 2023 · 13 comments · Fixed by #352
Closed

Support parameter for channel #345

Tenischev opened this issue Oct 22, 2023 · 13 comments · Fixed by #352
Assignees
Labels
bounty AsyncAPI Bounty program related label bounty/2023-Q4 AsyncAPI Bounty program related label enhancement New feature or request level/medium AsyncAPI Bounty program related label released

Comments

@Tenischev
Copy link
Member

Tenischev commented Oct 22, 2023

Reason/Context

This is long missed feature of template to support parameters for channel object.

Description

Support of parameters should be introduced for all protocols currently supported by template (kafka, mqtt, amqp).
Changes required in following files:

  1. General support:
    To support in kafka follow to reference doc, RoutingKafkaTemplate to send, containerFactory to receive.
    To support in amqp follow to reference doc topic exchange
    To support in mqtt follow to reference doc, topicExpression to receive and send, to send MessageHandler also should be adopted.

  2. Arbitrary methods
    Parametrized methods should be provided, e.g. for channel lights/{roomName}/{sensorID} method like

public void <operationName>(String roomName, Integer sensorID, Message payload)
@Tenischev Tenischev added the enhancement New feature or request label Oct 22, 2023
@AayushSaini101
Copy link

AayushSaini101 commented Oct 26, 2023

@Tenischev I would like to work on this issue

@Tenischev
Copy link
Member Author

Hey @AayushSaini101
This issue submitted for the Bounty program. So, I would prefer to wait end of submission period and election. If issue will be part of Bounty program, priorities of participants (if there will be a few) is follow:

1. AsyncAPI Maintainers (from any repository)

2. Regular contributors (GitHub users who have three or more Pull Requests merged throughout the AsyncAPI GitHub Organization)

3. Other (if a GitHub user doesn't fall under the above, the AsyncAPI Maintainer can determine the criteria i. e. regular volunteers, etc)

@AayushSaini101
Copy link

Hey @AayushSaini101 This issue submitted for the Bounty program. So, I would prefer to wait end of submission period and election. If issue will be part of Bounty program, priorities of participants (if there will be a few) is follow:

1. AsyncAPI Maintainers (from any repository)

2. Regular contributors (GitHub users who have three or more Pull Requests merged throughout the AsyncAPI GitHub Organization)

3. Other (if a GitHub user doesn't fall under the above, the AsyncAPI Maintainer can determine the criteria i. e. regular volunteers, etc)

Hi @Tenischev I have already contributed in Asyncapi these are my accepted MR https://github.com/asyncapi/cli/pulls?q=is%3Apr+author%3A%40me+is%3Aclosed. Please let me know if i can work on this

@aeworxet
Copy link

Correct link would be
https://github.com/search?q=is%3Apr+author%3AAayushSaini101+org%3Aasyncapi+is%3Amerged
There are three merged pull requests throughout the AsyncAPI GitHub Organization, so @AayushSaini101 falls into the second category, and would be eligible to work on this issue if it gets selected for Bounty Program 2023-Q4 and there are no AsyncAPI Maintainers willing to take on it.

@aeworxet aeworxet added bounty AsyncAPI Bounty program related label level/medium AsyncAPI Bounty program related label bounty/2023-Q4 AsyncAPI Bounty program related label labels Nov 6, 2023
@Tenischev
Copy link
Member Author

Since the second bounty task from this repo is closed, I would like to take on this one.

@aeworxet
Copy link

aeworxet commented Nov 7, 2023

Bounty Issue's End Of Life (EOL): 2024-02-29 23:59:59 UTC-12:00

@Tenischev Tenischev self-assigned this Nov 7, 2023
@aeworxet
Copy link

aeworxet commented Nov 7, 2023

Bounty Issue's Timeline

Complexity Level Assignment date (by GitHub) Start date (by BP rules) End date (by BP rules) Draft PR submission Final PR submission Final PR merge
Medium 2023-11-07 2023-11-13 2023-12-22 2023-11-24 2023-12-08 2023-12-22
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.

@aeworxet
Copy link

Please provide an update to the PR.

@Tenischev
Copy link
Member Author

@aeworxet sorry, i underestimate the issue complexity.
I would say currently issue implemented on 80% in draft PR, most complicated part is done.
I do my best to finish it on this working week.

@Tenischev
Copy link
Member Author

@aeworxet PR ready for review
@derberg please 🙏

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aeworxet
Copy link

Bounty Issue Completed 🎉

Please go to the AsyncAPI's OpenCollective page and submit an invoice for USD 200.00 with the subject Bounty java-spring-template#345, tag bounty.

@aeworxet
Copy link

@asyncapi/bounty_team

@aeworxet aeworxet moved this to Completed in Bounty Program Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty program related label bounty/2023-Q4 AsyncAPI Bounty program related label enhancement New feature or request level/medium AsyncAPI Bounty program related label released
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants