Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed mismatch between lastParticipatedVoteTime and isVotedInLast3Months #1615

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kunstewi
Copy link

@kunstewi kunstewi commented Dec 9, 2024

  1. I read the contribution guidelines
  2. No test issues whatsoever.
  3. Updated relevant files.

Description

Related issue(s)

Resolves issue #1614

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@kunstewi kunstewi changed the title fixed mismatch between lastParticipatedVoteTime and isVotedInLast3Months fix: fixed mismatch between lastParticipatedVoteTime and isVotedInLast3Months Dec 9, 2024
@derberg
Copy link
Member

derberg commented Dec 16, 2024

@kunstewi thanks for the PR. The goal should be not just to adopt the markdown file, but also to update the code that does wrong calculations. Can you update this PR to fix https://github.com/asyncapi/community/blob/master/.github/scripts/vote_tracker.js as well?

@kunstewi
Copy link
Author

kunstewi commented Dec 16, 2024

@kunstewi thanks for the PR. The goal should be not just to adopt the markdown file, but also to update the code that does wrong calculations. Can you update this PR to fix https://github.com/asyncapi/community/blob/master/.github/scripts/vote_tracker.js as well?

Definitely Sir, i would be looking into this right on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants