Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0 - why not? #761

Closed
derberg opened this issue Sep 7, 2023 · 9 comments · Fixed by #764
Closed

Release 1.0 - why not? #761

derberg opened this issue Sep 7, 2023 · 9 comments · Fixed by #764
Labels
question Further information is requested

Comments

@derberg
Copy link
Member

derberg commented Sep 7, 2023

Is there any reason why not release v1 "tomorrow" (like merge next into master)

  • We publish release candidates for like almost over 2y I think
  • But still master is default branch that people read
  • CI/CD issues occur as only master get updates automatically. This causes maintenance issues and hiccups (like /rtm do not work)

cc codeowners @magicmatatjahu @fmvilas


Is there anyone having an argument against it?

@derberg derberg added the question Further information is requested label Sep 7, 2023
@fmvilas
Copy link
Member

fmvilas commented Sep 7, 2023

Nope. All for it 👍

@magicmatatjahu
Copy link
Member

yeah, We can publish :)

@GreenRover
Copy link
Contributor

I would love this to!

@jonaslagoni
Copy link
Member

The playground is currently not working on next, I have tried to fix it for a week now, but this obscure react-app-rewired and it's build system is just not playing ball at all...

@jonaslagoni
Copy link
Member

jonaslagoni commented Sep 11, 2023

The playground is currently not working on next, I have tried to fix it for a week now, but this obscure react-app-rewired and it's build system is just not playing ball at all...

It's funny, as soon as I write this, I re-tested an implementation I did last week, and now everything magically works...

Checkout #763

@jonaslagoni
Copy link
Member

After playground is fixed I would release the library as v1 for sure 👍

@derberg
Copy link
Member Author

derberg commented Sep 13, 2023

once we have #767 merged, I think we are ready to go with v1 release

@derberg
Copy link
Member Author

derberg commented Sep 14, 2023

@magicmatatjahu @fmvilas #764 is ready for final review. Merge conflicts solved. Playground works. Tests pass. I think we are ready to go. In case of issues, we can always do a followup fixes 🤷🏼

@derberg
Copy link
Member Author

derberg commented Oct 2, 2023

it is out https://github.com/asyncapi/asyncapi-react/releases/tag/v1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants