Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an efficient all_subtypes function #807

Open
hunterhector opened this issue May 25, 2022 · 1 comment
Open

Create an efficient all_subtypes function #807

hunterhector opened this issue May 25, 2022 · 1 comment

Comments

@hunterhector
Copy link
Member

Is your feature request related to a problem? Please describe.
Getting all subtypes of a certain type in the data store is used in multiple places (1, 2), but could be implemented inefficiently and can be wrong. We should create one single function for this.

Describe the solution you'd like
The solution should consider:

  1. Caching results so get subtype won't be doing the same thing repeatedly
  2. Make sure the subtype orders and everything is the same across different calls (sorting the output)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

  • This is part of the data efficiency project
  • This PR should be made to the master branch.
  • After the data tuple class is finished, we may switch to a new branch for integration.
@hunterhector
Copy link
Member Author

@J007X could be a source for efficiency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant