Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the test test_marking_operations #177

Open
mwcraig opened this issue Sep 8, 2023 · 0 comments
Open

Refactor the test test_marking_operations #177

mwcraig opened this issue Sep 8, 2023 · 0 comments
Assignees
Labels

Comments

@mwcraig
Copy link
Member

mwcraig commented Sep 8, 2023

This single test checks several things. I think this should be brokeninto separate tests with clearer names. Right it checks that:

  • an empty table returned by get_markers has the correct columns.
  • the is_marking attribute is not settable.
  • setting the marker style actually changes the marker properties
  • calling start_marking changes the properties click_center, click_drag, and scroll_pan
  • calling stop_marking returns those properties back the the values they had before start_marking was called, i.e. check that property cacheing is implemented.
  • no warning is issued when retrieving a marker set that does not exist
  • recheck that start/stop marking caches properly
  • checks that a simulated mouse click adds a marker --> this is implementation is ginga- specific <-- so it should be removed
@mwcraig mwcraig added the testing label Sep 8, 2023
@mwcraig mwcraig self-assigned this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant