Markers API refactor #145
Closed
Markers API refactor #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and change it to namedtuple
and let it be defined via method calls.
|
Doh, Actions got deactivated. Closing/re-opening to see if it comes back alive. |
|
I'll review over the weekend or early next week -- maybe we can try to meet with @eteq at some point early in the week? |
|
Has this been superseded by #142 ? I cannot keep track anymore. |
🤷♂️ Hasn't been decided yet, I think, since we didn't quite get there in the meeting yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #141
Fix #143
This will propagate to Jdaviz/Imviz too, so once this is merged, I'd rather not change it ever again. Please review carefully. Thanks!
p.s. Note that this change is not backward compatible.