Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change marker from a dictionary to a class or namedtuple, and change the name from marker to marker_style #143

Open
mwcraig opened this issue Jul 2, 2021 · 2 comments
Labels
API Issues that relate to the API itself rather than implementations enhancement New feature or request Feature Request

Comments

@mwcraig
Copy link
Member

mwcraig commented Jul 2, 2021

Right now I have to either read the source code or set iw.marker to a value I know is bad so that I can be reminded of what the keys/values are for a marker.

If we changed it to a class (or a named tuple) then I could also introspect to get the attributes.

I would also find it clearer if the name were marker_style.

Finally, in an ideal world, we might agree on a few basic shapes and colors that viewers implementing the interface need to support.

@mwcraig mwcraig added enhancement New feature or request Feature Request labels Jul 2, 2021
@pllim
Copy link
Member

pllim commented Jul 6, 2021

I agree marker_style is a better name. Nothing against new interface either but would like to see what @eteq thinks.

As for the "basic" supported values and validation, that is trickier because it is very backend specific. Over at glue-jupyter + bqplot, I can't even find a way to change the shape yet (always circles for now).

@pllim pllim added the API Issues that relate to the API itself rather than implementations label Jun 16, 2023
@pllim
Copy link
Member

pllim commented Jun 28, 2023

Revisiting this, maybe better as https://docs.python.org/3/library/dataclasses.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues that relate to the API itself rather than implementations enhancement New feature or request Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants