Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to deal with astropy regions #137

Open
pllim opened this issue May 20, 2021 · 2 comments
Open

Add API to deal with astropy regions #137

pllim opened this issue May 20, 2021 · 2 comments
Labels
API Issues that relate to the API itself rather than implementations Feature Request

Comments

@pllim
Copy link
Member

pllim commented May 20, 2021

Similar to what @eteq laid out in spacetelescope/jdaviz#622 . But if he has something more specific than that for astrowidgets, feel free to clarify here. Thanks!

xref #51

@pllim pllim added backend: Protocol API Issues that relate to the API itself rather than implementations and removed API: Protocol labels Jun 16, 2023
@pllim
Copy link
Member Author

pllim commented Aug 31, 2023

and

self.marker = {'type': 'circle', 'color': 'cyan', 'radius': 20}

are analogous to regions.RegionVisual in purpose, but the regions implementation seems to be very specific to Matplotlib. For instance, it has no concept of alpha because Matplotlib embeds that into its color as RGBA (https://stackoverflow.com/questions/15928539/matplotlib-how-to-make-the-marker-face-color-transparent-without-making-the-li).

Therefore, I am not sure if RegionVisual is useful for backend-agnostic implementation.

@pllim
Copy link
Member Author

pllim commented Sep 6, 2023

We can look at an exploratory concrete implementation at spacetelescope/jdaviz#2410 to discuss this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues that relate to the API itself rather than implementations Feature Request
Projects
None yet
Development

No branches or pull requests

1 participant