Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong profile mapping for SnowflakePrivateKeyPemProfileMapping #479

Closed
nacpacheco opened this issue Aug 21, 2023 · 2 comments · Fixed by #501
Closed

Wrong profile mapping for SnowflakePrivateKeyPemProfileMapping #479

nacpacheco opened this issue Aug 21, 2023 · 2 comments · Fixed by #501
Labels
good first issue Good for newcomers
Milestone
1.1.0

Comments

@nacpacheco
Copy link
Contributor

SnowflakePrivateKeyPemProfileMapping is adding private_key_content to the DBT profile when in fact dbt is expecting the setting to be named private_key

dbt docs:
image

log from cosmos:
image

This makes dbt still try to find a password
@jlaneve
Copy link
Collaborator

jlaneve commented Aug 21, 2023

Hey @nacpacheco, thanks for opening this! Any interest in opening a PR to fix the issue? Should be a fairly straightforward change 🙂

@tatiana tatiana added the good first issue Good for newcomers label Aug 22, 2023
@nacpacheco nacpacheco mentioned this issue Aug 30, 2023
Merged
2 tasks
@nacpacheco
Copy link
Contributor Author

nacpacheco commented Aug 30, 2023 •
edited
Loading

Hi @jlaneve just opened the following PR with the fix, looking forward to the review :)

tatiana pushed a commit that referenced this issue Aug 31, 2023
@nacpacheco
Fix SnowflakePrivateKeyPemProfileMapping private_key reference (#501)
8c9e768 
Renamed key for Snowflake profile mapping from private_key_content to
private_key as expected by DBT

Tested locally with Airflow Snowflake Connection containing
extra.private_key_content

Closes #479
@tatiana tatiana added this to the 1.1.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Fix SnowflakePrivateKeyPemProfileMapping private_key reference nacpacheco/astronomer-cosmos
3 participants
@tatiana @jlaneve @nacpacheco