Add task timeout support. #1317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
dosubot
bot
added
the
area:rendering
t0momi219
commented
Nov 12, 2024
pankajkoti
reviewed
Nov 12, 2024
dosubot
bot
added
size:M
|
Hi @pankajkoti , |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
=======================================
Coverage 95.85% 95.85%
=======================================
Files 67 67
Lines 3979 3982 +3
=======================================
+ Hits 3814 3817 +3
Misses 165 165 ☔ View full report in Codecov by Sentry. |
pankajkoti
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
LGTM. some minor suggestion inline. Thanks for dropping the SLA piece. Could you please also update the PR title & description to drop SLA & additionally reflect the renamed config key cosmos_task_timeout?
We could merge this once these minor changes are addressed & meantime hopefully @tatiana and/or @pankajastro could also get a chance to review this PR.
t0momi219
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Airflow, both DAGs and tasks can have timeout specified. Since dbt models likely have varying expected execution times for each layer, there could be cases where users want to apply timeout individually to each node.
How about having Cosmos retrieve timeout from the node metadata and apply them individually when rendering nodes?
Specifically, the expected time is specified in the model's config, which will be read accordingly.
Related Issue(s)
closes #1316
Breaking Change?
Checklist