Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Create/Update/Logs deployment methods arguments to a struct #1709

Open
neel-astro opened this issue Aug 27, 2024 · 0 comments
Open

Comments

@neel-astro
Copy link
Contributor

As of now the create/update/logs deployment methods take in a load of individual arguments which are deployment properties, these arguments should be consolidated into a struct which would simplify calling the method, and help us avoid any potential issues concerning unordered arguments.

Code Reference:
Create function: https://github.com/astronomer/astro-cli/blob/main/cloud/deployment/deployment.go#L215
Update function: https://github.com/astronomer/astro-cli/blob/main/cloud/deployment/deployment.go#L741
Logs function: https://github.com/astronomer/astro-cli/blob/main/cloud/deployment/deployment.go#L138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant