Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cloud/deployment unit tests #1698

Open
neel-astro opened this issue Aug 8, 2024 · 0 comments
Open

Improve cloud/deployment unit tests #1698

neel-astro opened this issue Aug 8, 2024 · 0 comments
Labels
good-first-issue kind/tech-debt

Comments

@neel-astro
Copy link
Contributor

Description:

The existing unit tests in the cloud/deployment/deployment_test.go leak state between tests, and also have scope to move some of the tests to table-driven tests to reduce the duplicated code. Also, we should move to testify/suite as we did for some of the other tests recently (#1185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue kind/tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neel-astro @robshea-astro