Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to set class schema for check_schema and create_schema tasks #108

Open
mpgreg opened this issue Nov 13, 2023 · 1 comment
Open

Need to set class schema for check_schema and create_schema tasks #108

mpgreg opened this issue Nov 13, 2023 · 1 comment

Comments

@mpgreg
Copy link
Contributor

mpgreg commented Nov 13, 2023

https://github.com/astronomer/ask-astro/blob/c45487c7f12a9424dbe885580c687e35e30b7de4/airflow/dags/ingestion/ask-astro-load.py#L18C10-L18C10

The class awareness was added in c45487c but the json schema file still references "Docs".

The check_schema and create_schema tasks will need some logic to update the class name.
mpgreg added a commit to mpgreg/ask-astro-upstream that referenced this issue Nov 13, 2023
@mpgreg
fixes astronomer#105, astronomer#106, astronomer#107, astronomer#108
931d0ae
@mpgreg mpgreg mentioned this issue Nov 13, 2023
Closed
sunank200 pushed a commit that referenced this issue Nov 17, 2023
@mpgreg @sunank200
fixes #105, #106, #107, #108
657175a
sunank200 pushed a commit that referenced this issue Nov 20, 2023
@mpgreg @sunank200
fixes #105, #106, #107, #108
000a918
sunank200 pushed a commit that referenced this issue Nov 23, 2023
@mpgreg @sunank200
fixes #105, #106, #107, #108
b16e431
@sunank200
Copy link
Collaborator

@mpgreg is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunank200 @mpgreg