Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cython and add JAX #251

Merged
merged 27 commits into from
Nov 13, 2023
Merged

Remove cython and add JAX #251

merged 27 commits into from
Nov 13, 2023

Conversation

alicjapolanska
Copy link
Collaborator

Remove Cython from evidence and chains modules.

This was linked to issues Nov 1, 2023
Remove cython from everywhere except legacy models #243
Closed
JAXify #252
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
harmonic/__init__.py 100.00% <ø> (ø)
harmonic/model.py 99.19% <100.00%> (ø)
harmonic/model_abstract.py 100.00% <100.00%> (ø)
harmonic/model_legacy.pyx 96.74% <100.00%> (ø)
harmonic/utils.pyx 56.75% <100.00%> (ø)
harmonic/chains.py 95.80% <98.30%> (ø)
harmonic/evidence.py 95.87% <98.90%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@alicjapolanska alicjapolanska changed the title Remove cython Remove cython and add JAX Nov 2, 2023
This was linked to issues Nov 2, 2023
temperature_diagram example should check if running as script #258
Closed
Correct plot_getdist_compare docstring #256
Closed
@alicjapolanska alicjapolanska marked this pull request as draft November 2, 2023 14:49
@alicjapolanska alicjapolanska marked this pull request as ready for review November 3, 2023 16:59
@alicjapolanska alicjapolanska marked this pull request as draft November 3, 2023 17:06
@alicjapolanska alicjapolanska marked this pull request as ready for review November 13, 2023 11:52
CosmoMatt
CosmoMatt approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@CosmoMatt CosmoMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alicjapolanska alicjapolanska merged commit 1c2370e into main Nov 13, 2023
2 of 3 checks passed
@alicjapolanska alicjapolanska deleted the remove_cython branch November 13, 2023 12:28
This was linked to issues Nov 13, 2023
There are a number of TODos in the related to flow additions that should be addressed #259
Closed
Allow non-batched inputs to model.predict #264
Closed
Revamp basic usage tutorial #270
Closed
@alicjapolanska alicjapolanska removed a link to an issue Nov 13, 2023
Revamp basic usage tutorial #270
Closed
@alicjapolanska alicjapolanska mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CosmoMatt CosmoMatt CosmoMatt approved these changes

@jasonmcewen jasonmcewen jasonmcewen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alicjapolanska @jasonmcewen @CosmoMatt