-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action to add file-level ignore on violation #253
Comments
My only concern would be that we're starting to accumulate a lot of quick fix actions 😂 |
That, and I don't think suppressing an entire violation for an entire file is something we want to encourage. How do other linter solve this? Could we add a command instead? |
I think it makes a lot more sense as a code-action than a command. A command feels like we're encouraging it more i.e. you can apply it to multiple files at once. A code-action is like.. do this manually once.
I guess the other option is to suggest using |
FWIW, Lua language server provides 3 options (line, file, workspace): |
A quick fix for a violation shows an option to "Ignore the violation on this line", I'd like the additional option to "Ignore the violation in this file" which would be useful since I don't necessarily remember the syntax to do so :)
The text was updated successfully, but these errors were encountered: