Quick fix for XUMX in torch 2.0 #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the PR ! @r-sawata, do you agree ? |
|
Yea I confirmed this PR and actually tried to run it on my local. It looks having no any problems and will be suitable for future update of PyTorch, so I totally agree with this PR. Thank you so much for your PR, @DavidDiazGuerra. Could you merge this to master if you're fine, @mpariente? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I know we should ideally rewrite the XUMX model to work with the new torch's complex type, but it is possible to workaround this by just converting the new type to the old format just after calling
torch.stftusingtorch.view_as_realand then converting it back to the new type withtorch.view_as_complexbefore calling totorch.istft(#662) . This is not the ideal solution but I think it would be useful to allow people to keep using XUMX till the model is fully rewrited.Best,
David