Replies: 1 comment 2 replies
-
This is a very good point, thank you for your feedback. It was initially to keep the model, optimizer, data independant from the code of the LightningModule to make things clearer, and keep the users from having to write the training logic every time. But Lightning has evolved a LOT since then, and I agree that it doesn't make sense anymore. Do you want to contribute to move to the next/new version of Asteroid ? |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Looking at some simple examples of the usage of System in Asteroid, it seems not to have any benefit on the option of using
LightningModule+LightningDataModule, while also not preserving the cool idea in Lightning where the datamodule and the model+optimizer+etc module are agnostic and one can be changed without changing the other.
In my opinion the System class should be removed.
Beta Was this translation helpful? Give feedback.
All reactions