Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-zopfli package seems no longer maintained #625

Closed
plroebuck opened this issue Oct 14, 2018 · 5 comments
Closed

node-zopfli package seems no longer maintained #625

plroebuck opened this issue Oct 14, 2018 · 5 comments

Comments

@plroebuck
Copy link

Seemingly abandoned multiple months back. Binaries no longer available from AWS.

Options

bruce-one/node-zopfli fork was reported to work.

This worked for me, but I have build tools installed

$ npm install --build-from-source node-zopfli
@papandreou
Copy link
Member

Hmm, depressing.

bruce-one's fork doesn't seem to be published as an npm package, and npm i bruce-one/node-zopfli fails on my Ubuntu box: https://gist.github.com/papandreou/6bf1fd441dc96c3062296fbb6a1b07e6

@papandreou
Copy link
Member

We have the current node-zopfli as an optional dependency, so npm install should still succeed and we should handle it gracefully?

"node-zopfli": "2.0.2"

@plroebuck
Copy link
Author

plroebuck commented Oct 14, 2018

As a user, I saw an error attempting installation. Yes, AG-B installed, but people unaware of the optional nature would think the whole thing failed...

Maybe use a self-provided fork instead?

@salomvary
Copy link
Contributor

👍 for removing this dependency. Even though it is an optional dependency, each time npm install is run it will try to install node-zopfli flooding the terminal with warnings and error messages.

@papandreou
Copy link
Member

Already underway in #633 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants