Template tests #163
Open
Template tests #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #163 +/- ##
==========================================
+ Coverage 43.67% 52.01% +8.33%
==========================================
Files 64 70 +6
Lines 5946 6287 +341
==========================================
+ Hits 2597 3270 +673
+ Misses 3349 3017 -332
Continue to review full report at Codecov.
|
ODiogoSilva
reviewed
Nov 15, 2018
| } | ||
| } | ||
|
|
||
| # |
|
|
||
| def test_generate_jsons(): | ||
| """ | ||
| Test if the returns from this function are the expected results |
There was a problem hiding this comment.
We haven't done this so far, but it would be good to have more informative comments. Ideally:
- What is this function testing
- What is the expected result
| assert os.path.isfile("{}_mapping.json".format(depth_file)) | ||
|
|
||
|
|
||
| def test_generate_report(fetch_file): |
There was a problem hiding this comment.
Does this test depends on the execution of another?
Co-Authored-By: tiagofilipe12 <[email protected]>
tiagofilipe12
force-pushed
the
template_tests
branch
from
3f055b4 to
485a794
Compare
|
Does anyone still remember why is this pending? 😆 |
ODiogoSilva
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first implementation of the tests for python templates available in flowcraft (related with issue #148 ). The basic idea is to place each test under
flowcraft.tests.template_testsin order to separate these tests from the core flowcraft tests.For now I have just added some tests to the
mash_screen,mash_distandmapping_patlascomponents, for example to check if files are generated. More complex templates might require other kinds of tests. But the idea here is to make your python templates as tested as possible in order to allow others to contribute without breaking functionality of the components.I have also changed the import in all templates so that they can be imported by pytest while running the tests.
This change is