Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Build and pack symbols for libuv #35

Open
muratg opened this issue Mar 19, 2018 · 9 comments
Open

Build and pack symbols for libuv #35

muratg opened this issue Mar 19, 2018 · 9 comments
Milestone

Comments

@muratg
Copy link
Contributor

muratg commented Mar 19, 2018

From @JunTaoLuo on February 23, 2018 2:4

The libuv packages we build do not have any corresponding debug symbols. We should explore how we can produce and pack debug symbols in a libuv symbols package and publish this to the symbols server.

cc @davidfowl @halter73 for libuv expertise
cc @Eilon @muratg for triage
cc @natemcmaster for including additional symbols packages in our build.

Copied from original issue: dotnet/aspnetcore#2898

@muratg
Copy link
Contributor Author

muratg commented Mar 19, 2018

From @halter73 on February 23, 2018 2:45

Are we going to include the symbols in the main nuget package or on a myget symbol server?

The last time we discussed this, I was told we were saving the old symbols so we could upload them to a symbol server retroactively.

@muratg
Copy link
Contributor Author

muratg commented Mar 19, 2018

From @JunTaoLuo on February 23, 2018 3:5

Apparently we produce these in the libuv-build-windows builds, e.g. $DROPSHARE\libuv-build-windows\dev\10077\build\symbols. We should package these into symbols nupkgs and publish these along with our other symbols.

@muratg
Copy link
Contributor Author

muratg commented Mar 19, 2018

From @davidfowl on March 16, 2018 9:54

@JunTaoLuo did we ever look at this?

@muratg
Copy link
Contributor Author

muratg commented Mar 19, 2018

From @JunTaoLuo on March 16, 2018 17:6

Nope we never triaged this. cc @muratg

@muratg
Copy link
Contributor Author

muratg commented Mar 19, 2018

From @Eilon on March 19, 2018 16:53

Should this bug go to one of our libuv repos?

@muratg
Copy link
Contributor Author

muratg commented Mar 19, 2018

From @JunTaoLuo on March 19, 2018 17:3

Yes, and we should do this the next time we build libuv

@Eilon
Copy link
Member

Eilon commented Mar 27, 2018

@muratg - candidate to move to RC?

@muratg
Copy link
Contributor Author

muratg commented Mar 27, 2018

@Eilon yes.

@muratg muratg modified the milestones: 2.1.0-preview2, 2.1.0-rc1, 2.2.0 Mar 27, 2018
@muratg
Copy link
Contributor Author

muratg commented Mar 28, 2018

Moving this further out. We're making Sockets the default so this is a little less important.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants