Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency to Microsoft.Tpl.Dataflow does not allow package manager console to update or reinstall all packages in a solution in one shot. #30

Open
dougbu opened this issue Sep 5, 2018 · 4 comments
Labels
1 - Ready enhancement New feature or request

Comments

@dougbu
Copy link
Member

dougbu commented Sep 5, 2018

From @nnoorbakhsh on August 28, 2018 21:22

I believe the dependency to Microsoft.Tpl.Dataflow should be removed, and most probably replaced with System.Threading.Tasks.Dataflow. The mentioned dependency causes package manager console to fail when trying to update or reinstall all Nuget packages in a solution (e.g. using update-package -reinstall), forcing the user to reinstall packages one-by-one, which can be tedious in a very large solution (e.g. with 100+ projects, which is my case). Found the following issue which was opened 1 year ago, but the same problem still persists today: https://github.com/dotnet/corefx/issues/24547 . Thank you in advance.

Copied from original issue: aspnet/WebHooks#323

@dougbu
Copy link
Member Author

dougbu commented Sep 5, 2018

@nnorbakhsh as far as I can see, none of the WebHooks packages have Microsoft.Tpl.Dataflow dependencies. Could you please be more specific about the offending package?

@dougbu
Copy link
Member Author

dougbu commented Sep 5, 2018

From @nnoorbakhsh on September 4, 2018 23:15

Hi, I am seeing the dependency in the latest version of "Microsoft.AspNet.WebHooks.Custom" which is currently on 1.2.1. I am attaching a screenshot as well directly from VS. I hope I have posted it to the right place here! There was no feedback link (in VS), so I clicked on the abuse link (out of frustration I have to admit, it gave me a really hard time and I lost many hours because of it), which right on top said "please do not use this form to report a bug in a package you are using", with a link to contact the owners of the package instead. I did that and someone from your team responded and suggested I open an issue here on Github.
microsoft aspnet webhooks custom

@dougbu
Copy link
Member Author

dougbu commented Sep 5, 2018

@nnookbakhsh ah, you're talking about a WebHooks package for .NET Framework. This is an issue for the aspnet/AspNetWebHooks repo. I'll move it there…

@dougbu
Copy link
Member Author

dougbu commented Sep 5, 2018

@nnoorbakhsh now that we're in the right place 😺, I've had a look around and agree the Microsoft.Tpl.Dataflow package is no longer listed. But, it remains available and projects that depend on a specific version (4.5.24 in the WebHooks case) build correctly. Actions such as update-package -reinstall will however fail.

In general, this issue aligns with #5 and #11. Giving it the same milestone and label.

@dougbu dougbu added enhancement New feature or request 1 - Ready labels Sep 5, 2018
@dougbu dougbu added this to the 1.3.0-preview1 milestone Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Ready enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant