Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: Ability to pass-in testonly to py_pytest_main #189

Closed
kpark-hrp opened this issue Sep 18, 2023 · 1 comment · Fixed by #190
Closed

[FR]: Ability to pass-in testonly to py_pytest_main #189

kpark-hrp opened this issue Sep 18, 2023 · 1 comment · Fixed by #190
Labels
enhancement New feature or request untriaged Requires traige

Comments

@kpark-hrp
Copy link
Contributor

What is the current behavior?

kwargs in py_pytest_main macro is only applied to the underlying _py_pytest_main rule. Thus, testonly does not get applied to the py_library rule which makes up the pytest entry point.

Describe the feature

It would be useful to be able to pass in testonly flag to the underlying py_library rule defined by the py_pytest_main macro.

Specifically here
@kpark-hrp kpark-hrp added the enhancement New feature or request label Sep 18, 2023
@github-actions github-actions bot added the untriaged Requires traige label Sep 18, 2023
@kpark-hrp
Copy link
Contributor Author

Also, data parameter would also be nice, so I can pass in like pytest.ini

@kpark-hrp kpark-hrp mentioned this issue Sep 18, 2023
Merged
alexeagle pushed a commit that referenced this issue Sep 18, 2023
@kpark-hrp
Add testonly and data parameters to py_pytest_main rule (#190)
218a202 
### Type of change

- New feature or functionality (change which adds functionality)

Adds 2 new **optional** parameters to `py_pytest_main(...)` rule: `data`
and `testonly`. These are standard arguments to the `py_library`. This
change simply exposes the arguments to the `py_pytest_main` rule

closes: #189 

### Test plan

- Covered by existing test cases
@github-project-automation github-project-automation bot moved this to ✅ Done in Open Source Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request untriaged Requires traige
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add testonly and data parameters to py_pytest_main rule
1 participant
@kpark-hrp