Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: support pnpm.onlyBuiltDependencies #1689

Closed
Tracked by #1671
jbedard opened this issue May 1, 2024 · 1 comment
Closed
Tracked by #1671

[FR]: support pnpm.onlyBuiltDependencies #1689

jbedard opened this issue May 1, 2024 · 1 comment
Assignees
@jbedard
Labels
enhancement New feature or request
Milestone
Breaking Changes ...

Comments

@jbedard
Copy link
Member

jbedard commented May 1, 2024 •
edited
Loading

What is the current behavior?

npm_translate_lock generates lifecycle hooks based on the pnpm-lock requiresBuild flag

Describe the feature

Pnpm supports limiting the lifecycle hooks that are run using pnpm.onlyBuiltDependencies, rules_js should respect this.

This may also be required for pnpm v9+ due to pnpm/pnpm@0e6b757
@jbedard jbedard added the enhancement New feature or request label May 1, 2024
@github-actions github-actions bot added the untriaged Requires traige label May 1, 2024
@jbedard jbedard self-assigned this May 3, 2024
@jbedard jbedard removed the untriaged Requires traige label May 3, 2024
@gregmagolan gregmagolan added this to the Breaking Changes (2.0) milestone May 6, 2024
@gregmagolan gregmagolan mentioned this issue May 6, 2024
Closed
21 tasks
@jbedard
Copy link
Member Author

jbedard commented May 14, 2024

Done: #1723

@jbedard jbedard closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbedard jbedard

Labels
enhancement New feature or request
Projects
None yet
Milestone
Breaking Changes (2.0)
Development

No branches or pull requests
2 participants
@jbedard @gregmagolan