[Bug]: Local NPM package don't transitively propagate node_modules

[pat-trunk-io]

What happened?

When creating a package with the rule npm_package, if it gets included in another package, the node_modules dependencies do not get propagated correctly (I think).

For example, have a package A with dependency typescript, and a package B with dependency on A, bazel-bin/packages/B/node_modules/A/node_modules does not exits, yet bazel-bin/packages/A/node_modules exists

Version

Development (host) and target OS/architectures: linux/amd64

Output of bazel --version: bazel 7.1.1

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 1.41.1

Language(s) and/or frameworks involved: typescript, skylark

How to reproduce

Created a minimal repro here: https://github.com/pat-trunk-io/npm_package_bug_repro

Success when:

pnpm i
node packages/B/main.mjs

Failure when:

bazel run //packages/B:script

It is entirely possible I am using the npm_package rule wrong, but I am converting quite a large codebase that access things through import.meta.url into the node_modules.

Any other information?

With a little guidance, I would be ready to help and implement the fix.

My mental model is that in @npm/defs.bzl something is missing to transitively propagate the node_modules deps.

[pat-trunk-io]

So looking at https://nodejs.org/api/modules.html#modules_loading_from_node_modules_folders
It seems aspect_rules depend on the behavior that it will look upwards for directory having a node_modules (which it does in the package_store)

Therefore using require.resolve(...) is the correct way to make the code behave correctly.