Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: pnpm_lock attribute is required, and npm_link_all_packages crashes without it #1643

Closed
hermanbanken opened this issue Apr 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@hermanbanken
Copy link

hermanbanken commented Apr 11, 2024

What happened?

pnpm_lock attribute is required, and npm_translate_lock/npm_link_all_packages crashes without it

npm_link_all_packages(
    name = "node_modules",
    npm_package_lock = "package-lock.json",
)

the result is

"/private/var/tmp/_bazel_hbanken/6eb9282852909c8b69369466f9cffc58/external/aspect_rules_js~1.35.0/npm/private/npm_translate_lock_state.bzl", line 200, column 31, in _init_patched_dependencies_labels
                for patch_info in priv["patched_dependencies"].values():
Error: key "patched_dependencies" not found in dictionary
ERROR: Skipping '//project-frontend:vitest': no such package '@aspect_rules_js~1.35.0~npm~npm//': key "patched_dependencies" not found in dictionary
WARNING: Target pattern parsing failed.

Version

Development (host) and target OS/architectures:

Output of bazel --version:

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

Language(s) and/or frameworks involved:

How to reproduce

https://github.com/hermanbanken/example-bazel-repo

Any other information?

https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1712854408495939

Jason Bedard 1 hour ago
@Herman Banken
want to file a bug for that? Just linking to your repo is enough, just so I have an issue to reference when fixing it really…

@hermanbanken hermanbanken added the bug Something isn't working label Apr 11, 2024
@github-actions github-actions bot added the untriaged Requires traige label Apr 11, 2024
@jbedard jbedard self-assigned this Apr 11, 2024
@jbedard jbedard removed the untriaged Requires traige label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants