Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 support #6

Open
jtrip opened this issue May 10, 2016 · 3 comments
Open

python3 support #6

jtrip opened this issue May 10, 2016 · 3 comments

Comments

@jtrip
Copy link

jtrip commented May 10, 2016

When I try to use this with Python 3.4 I am receiving an unexpected error.

Traceback (most recent call last):
 File "/usr/local/bin/journal", line 9, in <module>
   load_entry_point('journal==0.4.0', 'console_scripts', 'journal')()
 File "/usr/lib/python3/dist-packages/pkg_resources.py", line 356, in load_entry_point
   return get_distribution(dist).load_entry_point(group, name)
 File "/usr/lib/python3/dist-packages/pkg_resources.py", line 2476, in load_entry_point
   return ep.load()
 File "/usr/lib/python3/dist-packages/pkg_resources.py", line 2190, in load
   ['__name__'])
 File "/usr/local/lib/python3.4/dist-packages/journal/main.py", line 80
   print "journal: error: config file '" + args.config_file + "' not found"
                                       ^
SyntaxError: Missing parentheses in call to 'print'

I am tempted to see if I can fix it myself, just thought I would post here and see if you or anyone else had taken a look at Python 3 support. Maybe it is just fixing some print statements (easy) or maybe there will be more to it.

@askedrelic
Copy link
Owner

Fix away! I haven't touched this project in awhile, but it was written for Python 2.7. I'd support upgrading it to Py3.

My understanding is that targeting Py3.5 as the default and using 3to2 to backport makes sense, but I've also seen six used to support py2/3 at the same time.

@philerooski
Copy link
Contributor

I just submitted a pull request for python3 compatibility. It's my first ever pull request, so any feedback is appreciated!

@askedrelic
Copy link
Owner

congrats on your first PR @philerooski 🎆

I will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants