-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
many calls of WebSerial.println in a row causes problems #11
Comments
Thank you for using this library. I thought you meet the same problem mentioned in #4 Did the FAQ solve your problem? I currently think that in order to ensure the lightweight of the library, the function of caching messages should be implemented by AsyncWebSocket, because WebSerialLite cannot know whether the message queue in AsyncWebSocket has been emptied. |
There is a german proverb: I currently used this version of the AsyncWebserver: Because these are used at e.g. here: Is the ESPAsyncWebServer from ESPHome better? I have now increased the WS_MAX_QUEUED_MESSAGES to 32. What is about the menetoried "issue" int the AsyncTCP is this somehow related? |
ESPHome/ESPAsyncWebServer seems to be updating a bit more aggressively, so I was using ESPHome/ESPAsyncWebServer, and so that I submitted a PR to it, but the original version is actually ok, you can make a PR to the original version if you like. Actually I don't know which value of WS_MAX_QUEUED_MESSAGES if suitable for you, you'd better make some tests by yourselves. Sorry for can't help you. 😟 If you want to solve the issue about "many calls of WebSerial.println in a row causes problems", I thought change the WS_MAX_QUEUED_MESSAGES is enough. If you want to solve the issue me-no-dev/AsyncTCP#121 , I thought you can try to use https://github.com/yubox-node-org/AsyncTCPSock |
I thought the ESPAsyncWebServer you are using is cool! There are a lot of new features! I like it. |
The issue "many calls of WebSerial.println in a row causes problems" is fixed with changing value of WS_MAX_QUEUED_MESSAGES. Perfect :-) The other problem I pointed on I've already fixed by editing the AsyncTCP.cpp as described in me-no-dev/AsyncTCP#121. But now I'll try out our suggestion, it seems completely rewritten. |
Thanks for the report, I think the problem has been solved. Can I close this issue and mark it as resolved? |
I have one more question, but I am not sure if it is related to your library. What happens is this. |
Hi, I'm not sure if it's the same error. But I can gladly test it. |
Hi,
Brilliant libary!
I had big problems with stuttering output at the beginning.
Especially when many WebSerial.println came in a row in the skipt:
WebSerial.print ("Measurement_count: );
WebSerial.println (Measurement_count);
WebSerial.print ("Unix-Time: ");
WebSerial.println (now);
WebSerial.print ("Records in cache: );
WebSerial.println (queue.size());
After replacing this with the following, it worked better:
snprintf(printbuffer, sizeof(printbuffer), "Measurement_count: %i \nUnix-Time: %ld \nRecords in cache: %i", Measurement_count, now, queue.size());
WebSerial.println(printbuffer);
Also, I think it is very important to make an adjustment to the AsyncTCP:
me-no-dev/AsyncTCP#121
Without this change it kept crashing every few hours.
The text was updated successfully, but these errors were encountered: