Skip to content

Commit

Permalink
dynamic branch json file corruption during edkrepo sync
Browse files Browse the repository at this point in the history
tianocore#123

When determining branch collision, the patchset parent_sha value should not match the branch name.
If the patchset parent_sha value matches the branch name, continue testing the remaining patchsets.

Signed-off-by: Nathaniel Haller <[email protected]>
Reviewed-by: Ashley E Desimone <[email protected]>
  • Loading branch information
ndhaller authored and ashedesimone committed Feb 28, 2023
1 parent b418f74 commit 85cb6a3
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions edkrepo/common/common_repo_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,9 @@ def is_branch_name_collision(json_path, patchset_obj, repo, global_manifest_path
data = json.load(f)
patchset_data = data[repo_name]
for patchset in patchset_data:
if patchset_name == patchset['parent_sha']:
# Do not match a patchset branch name against a daisy-chained-patchset parent_sha value
continue
if patchset_name in patchset.values():
BRANCH_IN_JSON = True

Expand Down

0 comments on commit 85cb6a3

Please sign in to comment.