Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pagination default not included in upgrade guide #129

Closed
rgraff opened this issue Apr 15, 2024 · 1 comment
Closed

New pagination default not included in upgrade guide #129

rgraff opened this issue Apr 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rgraff
Copy link

rgraff commented Apr 15, 2024

In Ash GraphQL 1.0.0-rc.3, For list queries where the resource action has pagination, the graphql query now returns paginated results when previously it didn't.

I actually prefer this, but it is a change that I didn't see in the upgrade guide. I think the new default is :keyset if available.

@rgraff rgraff added the enhancement New feature or request label Apr 15, 2024
@zachdaniel
Copy link
Contributor

🤔 I'm confused TBH. I thought AshGraphql always does pagination if the action supports it? Was it not doing that before?

I think the thing that changed is that primary actions are now paginatable by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants