Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add after_transaction_batch hook #1564

Closed
yujonglee opened this issue Oct 30, 2024 · 2 comments
Closed

Add after_transaction_batch hook #1564

yujonglee opened this issue Oct 30, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yujonglee
Copy link

Is your feature request related to a problem? Please describe.

Currently, after_batch runs inside transaction. There's nothing I can do if I want to do some extra work after batch outside of transation.

Describe the solution you'd like

Add after_transaction_batch hook

Describe alternatives you've considered

Use after_transaction for individual changeset.

@yujonglee yujonglee added enhancement New feature or request needs review labels Oct 30, 2024
@zachdaniel zachdaniel added good first issue Good for newcomers and removed needs review labels Oct 30, 2024
@zachdaniel
Copy link
Contributor

I've labeled this as "good first issue", but it is actually reasonably complex. Its more like a "good second" or "good third" issue 😆 But its a digestible piece to add and would be very useful :)

@zachdaniel
Copy link
Contributor

Closing as a duplicate of #1580 (that one refers to both before and after batch hooks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

No branches or pull requests

2 participants