Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider automatically falling back to downloading x86-64 builds of nodejs on Apple Silicon machines if a native build isn't available. #313

Open
hutchisr opened this issue Aug 19, 2022 · 3 comments

Comments

@hutchisr
Copy link

If you try to install an older version of node without a precompiled arm binary, nvm will automatically download the x86-64 version instead. asdf-nodejs will instead try (and almost certainly fail) to compile the version from the source and to get a precompiled version the user has to manually specify the architecture by running $ arch -x86_64 asdf install nodejs <version> instead which is much less user friendly.

@augustobmoura
Copy link
Member

augustobmoura commented Sep 2, 2022

asdf-nodejs currently already tries to build the said version from source as a fallback. I'm not sure which behavior would be the most useful for mac users. It seems like most people are content with either building it or running arch -x86_64 for installing the x64 version

If this gets enough traction, we can try to think something about it, maybe an environment variable to control it

@gonejack
Copy link

gonejack commented Sep 4, 2022

It would be better to install x86_64 by default, because there are lot of precompiled npm dependencies in x86_64 that can not be invoked by nodejs in ARM.

@kitsunde
Copy link

kitsunde commented Jan 7, 2023

It would be a lot worse if we sometimes installed x86 ones and sometimes ARM ones without explicitly passing that as an option.

This could effectively be opting into a race condition where if the x86 binary gets published before the arm one, some users would be on x86 instead of ARM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants