Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support for installing poetry plugins #45

Open
jfly opened this issue Jun 6, 2024 · 2 comments
Open

Feature request: support for installing poetry plugins #45

jfly opened this issue Jun 6, 2024 · 2 comments

Comments

@jfly
Copy link

jfly commented Jun 6, 2024

It would be nice to be able to ensure poetry gets installed with some plugins.

I suppose it would require doing something quite clever with the .tool-versions format. A couple ideas:

  1. Add a special environment variable that contains a (comma separated?) list of plugins to install.
  • This feels unfortunate because it wouldn't give me any mechanism for using poetry 1.2.3 both with a given plugin and without a given plugin.
  1. Do something clever with asdf plugin naming. For example, folks could run asdf plugin-add poetry-with-FOO-with-BAR https://github.com/asdf-community/asdf-poetry.git and under the hood, asdf-plugin would parse the plugin name and install the given plugins (in this case, "FOO" and "BAR") when it installs a particular version of poetry.
    • This is quite a hack, but I think it would work. asdf doesn't seem to pass the plugin name down when invoking install, but we could deduce it from the location of the install script.
@jdx
Copy link

jdx commented Jun 6, 2024

Configuration is supported in mise.toml, that'd likely be the preferred strategy here. This works today, but the poetry plugin would need to look for the configuration and install the plugins

@jfly
Copy link
Author

jfly commented Jun 6, 2024

@jdx, for folks like me with no knowledge of mise, could you elaborate a little more? The 2 suggestions I included would work with pure asdf, would yours?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants