Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for table row fragments #493

Open
johthor opened this issue Mar 14, 2023 · 2 comments
Open

Support for table row fragments #493

johthor opened this issue Mar 14, 2023 · 2 comments

Comments

@johthor
Copy link

johthor commented Mar 14, 2023

Currently the step option on a table is translated into the class fragment on the resulting HTML table. This differs from the translation for ordered and unordered lists where the step option leads to the class fragment being applied to the list items instead of the list itself.

I would like to have a possibility to apply the the fragment class to the <tr> instead of the <table>. Which should be possible if I didn't miss any specifics.

For backwards compatibility reasons this most likely should be accomplished via a new option instead of changing the step option.

johthor added a commit to johthor/asciidoctor-reveal.js that referenced this issue Mar 23, 2023
@ggrossetie
Copy link
Member

Interesting idea... we might need to introduce an attribute to control if we want to step per line or not. Should we also support per column? and per row per column?

@johthor
Copy link
Author

johthor commented May 14, 2023

I did a small experiment where I took the implementation from lists and applied it to the table's rows via an option rowStep.
While adding fragment on <tr> elements was simple I'm not sure how revealing per column would be supported by reveal.js.

I found this open issue hakimel/reveal.js#2191. Otherwise the <td> would need to receive the class fragment and the data-fragment-index would need to be incremented by column and reset after each row to reveal all cells of a column at the same time (see https://revealjs.com/fragments/#fragment-order). The problem with that is, that I see a conflict between the automatic step order outside of the table and the forced step order inside the table.

I wouldn't want to support stepping per row per column. That would lead to some really busy slides. Although it would most likely be simpler than stepping only per column.

johthor added a commit to johthor/asciidoctor-reveal.js that referenced this issue Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants