Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename registration files #46

Closed
edusantana opened this issue Jun 7, 2015 · 1 comment
Closed

Rename registration files #46

edusantana opened this issue Jun 7, 2015 · 1 comment

Comments

@edusantana
Copy link
Contributor

It would be more verbose to rename files inside lib/*.rb to include registration in their names:

lib/chart-block-macro-registration.rb
lib/chrome-inline-macro-registration.rb
lib/copyright-footer-postprocessor-registration.rb
lib/emoji-inline-macro-registration.rb
(...)

It would avoid errors like #45.

@mojavelinux
Copy link
Member

I think this can be solved by the README. I'd rather not rename these files as this is not consistent with the Ruby way and the file names become too verbose.

In Ruby, the top-level name registers and activates the implementation files. That's how we've structured this repo. Once they are packaged in a gem (the long-term plan), the flag becomes -r gist-block-macro, which reads very nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants