This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
Current direction test. #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| flag_arr = np.ones_like(arr, dtype='uint8') | ||
|
|
||
| flag_arr[(arr < sensor_min) | | ||
| (arr > sensor_max)] = QCFlags.BAD_DATA |
There was a problem hiding this comment.
@lukecampbell we can implement this a special case of range_check() the same way I did for #65. Let me know which style works best for your goals here.
|
Ping @lukecampbell The failure is due to the masking and I am not sure if we should support it or nor. If we do not want to support masked arrays I can just remove that test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Current Direction Test. (Fixes #55.)
@lukecampbell
Note that the masked array test do fail on purpose. It is just to raise the question: should we support masked arrays?