Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add images to the human chapter #197

Open
ipg-sig opened this issue Nov 22, 2024 · 4 comments · May be fixed by #217
Open

Add images to the human chapter #197

ipg-sig opened this issue Nov 22, 2024 · 4 comments · May be fixed by #217
Assignees
@FKlopfer @ACMackenthun @ipg-sig
Labels
isState:New A new issue that needs to be classified to a type. isSubGroup:GEOMETRY isType:Feature An issue that adds new features to the project.
Milestone
v1.0.0

Comments

@ipg-sig
Copy link
Contributor

ipg-sig commented Nov 22, 2024

Is your feature request related to a problem? Please describe.
Please create and add images for the separate bones and there orientation (human-model-structure.adoc).
Please create and add an image for the human (human-general.adoc)

Describe the solution you'd like
Create and add images for the separate bones and there orientation.

Describe alternatives you've considered
Screenshots are too messy to use directly, but help to understand the orientation in 3D.

Additional context
The .blend file can be found in the sharepoint under Documents/03_Development/Work_Files/Human_Example_File.blend
Screenshots of the bones and there orientation can be found in the sharepoint under Documents/03_Development/Work_Files/Bones
@ipg-sig ipg-sig added isState:New A new issue that needs to be classified to a type. isType:Feature An issue that adds new features to the project. isSubGroup:GEOMETRY labels Nov 22, 2024
@FKlopfer
Copy link
Collaborator

@ipg-sig We were just wondering what the best approach is.
Should there be separate images for every bone or should there be one (or two) image(s) of the human body with a coordinate system and its orientation placed at the respective parts of the body (for example, this: https://github.com/asam-ev/OpenMATERIAL/blob/OpenMATERIAL_Legacy/model_structure/Pedestrian_Structure_Skeleton.svg) . For the vehicle structure, we also had only a few base models and placed the coordinate systems at different places (like this: https://asam-ev.github.io/OpenMATERIAL/asamopenmaterial/latest/specification/geometry/object-classes.html#_grp_door_front_door_front_idx). By this, readers gets a better overview and it makes it easier to create the images.

@FKlopfer
Copy link
Collaborator

FKlopfer commented Dec 2, 2024

@ClemensLinnhoff , can you help answering our question? We cannot start on this until we agree on the general approach.

@ipg-sig
Copy link
Contributor Author

ipg-sig commented Dec 2, 2024

@FKlopfer Good question. I think it might depend, if we can make the orientation of the bones clear via the text or tables. But I agree, that too many pictures could be confusing.
I think something like this "https://github.com/asam-ev/OpenMATERIAL/blob/OpenMATERIAL_Legacy/model_structure/Pedestrian_Structure_Skeleton.svg)" is needed in any case.

@ClemensLinnhoff
Copy link
Collaborator

I think it might make sense here to have one image showing all coordinates.

@ACMackenthun ACMackenthun linked a pull request Dec 5, 2024 that will close this issue
Added image for human skeleton #217
Open
2 tasks
@ClemensLinnhoff ClemensLinnhoff added this to the v1.0.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FKlopfer FKlopfer

@ACMackenthun ACMackenthun

@ipg-sig ipg-sig

Labels
isState:New A new issue that needs to be classified to a type. isSubGroup:GEOMETRY isType:Feature An issue that adds new features to the project.
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Added image for human skeleton asam-ev/OpenMATERIAL
4 participants
@ClemensLinnhoff @FKlopfer @ACMackenthun @ipg-sig