You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Large trees are and have always been difficult for prime. But we are not
dealing with it smart enough.
Currently, you get a division-by-zero error if a given start tree does not fit
well in the species tree. This happens at
se.cbb.jprime.mcmc.MetropolisHastingsAcceptor.acceptProposedState(MetropolisHastingsAcceptor.java:38)
or rather
se.cbb.jprime.math.LogDouble.div(LogDouble.java:309)
which is subsequently called.
I am not sure what the best behaviour is, but there should at least be an
explanation of why this happens. One could also consider allowing (with an
option) to ignore zero probability of a state and always accept new states.
Ideally, one would like to have a starting tree with non-zero probability, of
course.
Original issue reported on code.google.com by [email protected] on 21 Aug 2013 at 8:58
The text was updated successfully, but these errors were encountered:
With a small change in MCMCManager class, jprime should no longer give
divide-by-zero error. It will simply reject a state if its probability is not
greater than zero. Statistics of number of states accepted are shown in the
output.
Original issue reported on code.google.com by
[email protected]
on 21 Aug 2013 at 8:58The text was updated successfully, but these errors were encountered: