Bad design of Scorer (it was me)

[fredshone]

What can be improved?

Not urgent.

pam.scoring.PlanScorer as a nasty interface (score_person and score_plan). Config object (a nested dict with requiring particular nesting and keys) mostly to blame.

Suggest we design a matsim config file object that can be relied upon to provide a solid design here.

Might be worth using mc.build.Config(matsim_config.xml). This has the advantage of also describing which attribute key is being used (usually "subpopulation") and would allow matsim.xml to be used rather than carefully creating a new config. Obvious downside is that mc becomes a dependancy and we would presumably want to publish (it is already open however).

But thinking further ahead, this would facilitate cli commands such as optimise gridsearch PLANS_PATH CONFIG_PATH OUT_PATH.

Version

0.2.0