Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VM/lib] Merge constants and builtin's? #642

Closed
github-actions bot opened this issue Aug 3, 2022 · 6 comments
Closed

[VM/lib] Merge constants and builtin's? #642

github-actions bot opened this issue Aug 3, 2022 · 6 comments
Labels
enhancement New feature or request library Issues related to the standard library open discussion Open discussion about features/ideas/suggestions stale todo Automatically generated issues from TODOs in the code vm Issues related to the Virtual Machine implementation

Comments

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

[VM/lib] Merge constants and builtin's?

Do we really - really - need another "constant" type? I doubt it whether it makes any serious performance difference, with the only exception being constants like true, false, etc.

But then, it also over-complicates documentation generation for constants.

So, we should either make documentation possible for constants as well, or merge the two things into one concept

# TODO(VM/lib) Merge constants and builtin's?

            )

# TODO(VM/lib) Merge constants and builtin's?
#  Do we really - really - need another "constant" type? I doubt it whether it makes any serious performance difference, with the only exception being constants like `true`, `false`, etc.
#  But then, it also over-complicates documentation generation for constants.
#  So, we should either make documentation possible for constants as well, or merge the two things into one concept
#  labels: vm, library, enhancement, open discussion
template constant*(n: string, alias: SymbolKind, description: string, v: Value):untyped =
    Syms[n] = (v)
    Syms[n].info = "[" & static (instantiationInfo().filename).replace(".nim") & ":" & $(static (instantiationInfo().line)) & "] " & description
ndex e098b999e..4d261283b 100644
++ b/src/vm/package.nim

07c8d3ba9b413ceb346e0c3ce2d4dcf661f97847

@github-actions github-actions bot added enhancement New feature or request library Issues related to the standard library open discussion Open discussion about features/ideas/suggestions todo Automatically generated issues from TODOs in the code vm Issues related to the Virtual Machine implementation labels Aug 3, 2022
@stale
Copy link

stale bot commented Mar 31, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 31, 2023
@stale
Copy link

stale bot commented Jul 29, 2023

Closing issue as stale.

@stale stale bot closed this as completed Jul 29, 2023
@drkameleon
Copy link
Collaborator

Re-opening as still valid

@drkameleon drkameleon reopened this Jul 31, 2023
Copy link

stale bot commented Nov 29, 2023

Closing issue as stale.

@stale stale bot closed this as completed Nov 29, 2023
@drkameleon drkameleon reopened this Nov 29, 2023
@stale stale bot removed the stale label Nov 29, 2023
Copy link

stale bot commented Jul 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 27, 2024
Copy link

stale bot commented Nov 25, 2024

Closing issue as stale.

@stale stale bot closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request library Issues related to the standard library open discussion Open discussion about features/ideas/suggestions stale todo Automatically generated issues from TODOs in the code vm Issues related to the Virtual Machine implementation
Projects
None yet
Development

No branches or pull requests

1 participant