Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Elements / Inputs / Select #483

Open
7 of 19 tasks
owendodd opened this issue May 30, 2019 · 0 comments
Open
7 of 19 tasks

[Update] Elements / Inputs / Select #483

owendodd opened this issue May 30, 2019 · 0 comments

Comments

@owendodd
Copy link
Contributor

owendodd commented May 30, 2019

Component Name

Select

Zeplin link

zpl://screen?pid=5acd19ff49a1429169c3128b&sid=5cf0449804fcd97a2fe8a9cb

Product team

TBD

Design lead

@owendodd

Additional info

Adds custom dropdown implementation to Select element.

Checklists

Design

For Elements

Buttons, links, loaders, inputs, dropdowns, etc

  • Is it using up-to-date tokens from above?

  • Have all states been captured? (hover, selected, disabled, focused, normal, thinking, errors)

  • Have all transitions/animations been defined?

  • Is it useable? (Considering touch targets, screen sizes)

  • Is it consistent with the rest of the visual system? (Corner radius, stroke weight, form, shadow, opacity, etc)

  • Does it meet accessibility standards? (is it keyboard navigable, does it have required accessibility markup)

  • Does it render and function properly in Artsy supported browsers?

Engineering

Accessibility

  • Do all images and multimedia have alt or title tags?

  • Are semantic elements used appropriately (nav, button, etc)?

  • Are new components keyboard-navigable?

  • Are hover interactions available by other means?

  • Are aria- attributes included where appropriate?

  • Has a Chrome Devtools accessibility audit been performed?

Compatibility

Has the new component been reviewed in Browserstack:

  • Desktop Chrome

  • Desktop Edge

  • Desktop Safari

  • Desktop Firefox

  • Android

  • iOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant