Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hypertext compatible with the Language Selector Plugin #67

Open
handmeatowel opened this issue Nov 16, 2021 · 2 comments
Open

Make hypertext compatible with the Language Selector Plugin #67

handmeatowel opened this issue Nov 16, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@handmeatowel
Copy link

Make hypertext compatible with the Language Selector Plugin (text-only).

@artofthesmart
Copy link
Owner

Hmm; this is a bit more work than I have time for right now. I'm 99% certain I would only implement the text version of the plugin, no dropdowns or flag images or anything. Then I'd need to learn how Grav handles languages to make sure they're linked properly in the resultant links.

I'm going to cut a new release to get the new header image functionality out there and put this on the back burner. If a few more people upvote this I'll come around for another look.

@handmeatowel
Copy link
Author

handmeatowel commented Dec 13, 2021

Regarding the drop downs with hypertext I'd agree. If someone wanted to use hypertext with a drop down, it would be up to them to make the necessary changes to the theme as this would be counterproductive of the goals of hypertext. Could be done with some additional CSS perhaps.

Objectively speaking flag images for language selection don't make a lot of sense (they would for selecting a country, though). So I'd say you got that right as well :-)

Regarding theme work (which I'm unfortunately not capable of), perhaps this helps: https://discourse.getgrav.org/t/where-to-add-language-selector-code/17437
https://learn.getgrav.org/16/content/multi-language

@artofthesmart artofthesmart added the enhancement New feature or request label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants