Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a status condition to track when a resource template does not match #915

Open
gtully opened this issue Apr 29, 2024 · 2 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gtully
Copy link
Contributor

gtully commented Apr 29, 2024

With the resource template, the match criteria can be specific and match on a name. however if that name is incorrect, there is no validation, the template is ignored.
in that case, it would be nice to report an UnmatchedResourceTempate Condition in the Status.

not sure if this condition should mean Ready=false, it is indeed non fatal. lets discuss.

@gtully gtully added enhancement New feature or request good first issue Good for newcomers labels Apr 29, 2024
@brusdev
Copy link
Contributor

brusdev commented Apr 29, 2024

Non fatal sounds good to me.

@gtully
Copy link
Contributor Author

gtully commented May 2, 2024

actually thinking more, it is an invalid CR, and we know before we try and update, so we can make it a fatal condition. A variation of the ValidCondition with an unmatched resource template at [index] reason.

@Msarawan Msarawan self-assigned this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants