Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access violation on first run of second instance #36

Closed
billybednar opened this issue Jun 12, 2023 · 1 comment
Closed

Access violation on first run of second instance #36

billybednar opened this issue Jun 12, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@billybednar
Copy link

Describe the bug
While testing a fix to #35, I noticed that a fresh portable version (without a config.ini) will crash on its first run if another instance of the application (portable or installed) is already running. It also occurs if the config.ini file does not contain a "LastCheckForUpdates" line (but only if another instance is running).

To Reproduce

  1. Extract two copies of the portable version into different locations.
  2. Run the exe in the first location. The application window will open.
  3. Run the exe in the second location. The application window will briefly open, then close with an error message (text here, screenshot below). A config.ini will also be generated.
  4. Run the exe in the second location again. The application window will briefly open and close without error.
  5. Delete the config.ini file from the second location.
  6. Run the exe in the second location. The error returns. A new config.ini will be generated.
  7. Edit the config.ini file in the second location to remove the "LastCheckForUpdates=..." line and add a "Logging=1" line.
  8. Run the exe in the second location. The error occurs again.

Expected behavior
The second instance always exits cleanly without crashing, ideally after restoring and activating the already running instance.

Screenshots
image

Version
1.11 portable + 1.11 portable, 1.10.4 installed + 1.11-3-g7872c3e-dirty

OS
Windows 10 Pro 22H2 (build 19045.2965), 64 bit

Log file
log.txt (from the second instance; nothing extra is added to the first)

@artem78 artem78 added the bug Something isn't working label Jun 23, 2023
@artem78
Copy link
Owner

artem78 commented Jun 24, 2023

Fixed in v1.12.

@artem78 artem78 closed this as completed Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants